build error in zm_event.h (zm-1.18.1)

[seanster]

zm_event.h needs a #include <sys/time.h>

>In file included from zm_event.cpp:29:
>zm_event.h:53: error: field `start_time' has incomplete type
>zm_event.h:54: error: field `end_time' has incomplete type
>zm_event.h: In member function `const timeval& Event::StartTime() const':
>zm_event.h:81: error: `start_time' undeclared (first use this function)

make ran fine after adding the include

-Sean

[zoneminder]

Hi Sean,

Which distro and version are you using? I've not any reports of this before.

Phil,

[seanster]

My system is based upon an ancient redhat 6.2, but I have not used RPMs in years. Almost everything is installed from generic source.

Linux 2.6.2
gcc (GCC) 3.3.2
perl, v5.8.3 built for i586-linux

About the only thing that isn't new is glibc. I have yet to tackle that one.
I'm using glibc 2.2.1 and maybe that's the culprit.

I just noticed that the forum stole the filename i said needed including.

it was supposed to read: #include sys/time.h (in angle brackets of course)

The question would be where is the "struct timeval" declared? If it's still in sys/time.h then it really ought to be included and not depended upon as a side effect of some other include.

I have some other bugfix patches. To whom should I send these patches, or do I just post them here? Is there a mailing list?

Thanks,
Sean

[zoneminder]

Hi Sean,

Feel free to send any patches to me <a href="mailto:philip.coombes@zoneminder.com">here</a>.

Phil,