ZM 1.19.(3 or 4) BUG DISCOVERED AND FIXED

Support and queries relating to all previous versions of ZoneMinder
Locked
User avatar
victor_diago
Posts: 245
Joined: Wed Jan 21, 2004 2:44 pm
Location: Brazil, sao paulo
Contact:

ZM 1.19.(3 or 4) BUG DISCOVERED AND FIXED

Post by victor_diago »

hi al..

zm has a little bug in zm_html_view_event.php
when you use mpeg streaming WITH some dumb plugin (like mplayer-plugin for linux and mozilla) the image gets cuted. its show 320 in width but height arent right.

looking there i ve found these lines

<EMBED type="video/mpeg"
src="<?= $stream_src ?>"
width=<?= reScale( $event['Width'], $scale ) ?>
height=<?= reScale( $event['Height'], $scale ) ?>
AutoStart=true>
</EMBED>

then i ve just quoted the width and height lines

width="<?= reScale( $event['Width'], $scale ) ?>"
height="<?= reScale( $event['Height'], $scale ) ?>"

then everything went right.

this could be at montage view too. i will check.

in windows this change is not relevant since windows media player show the image correct. maybe a little fix to put in another version phil ?

victor diago
User avatar
victor_diago
Posts: 245
Joined: Wed Jan 21, 2004 2:44 pm
Location: Brazil, sao paulo
Contact:

Post by victor_diago »

does this matter for anyone ?
User avatar
zoneminder
Site Admin
Posts: 5215
Joined: Wed Jul 09, 2003 2:07 pm
Location: Bristol, UK
Contact:

Post by zoneminder »

Hi Victor,

I've made a note to check and correct any instances I find in the source. I think in most cases though browsers tend to handle x=y the same as x="y" but there may be some circumstances where this isn't the case.

Phil,
Locked