Zoneminder web interface window sizes?

[robi]

Hi devs!

Could you please give me a hint where to look for, in the PHP code for the browser popup window sizes?
In the translated interface several strings are longer than in English, and things don't fit well in the windows. In most cases widening them just a bit would fix the issue.

I'd send in the patches later, I promise.

[kylejohnson]

Hey Robi,

These should be in web/skins/classic/js/skin.js

For future reference, please base your code branches off of the 'develop' github branch.
For example, you would git clone zoneminder && cd zoneminder && git checkout develop && git checkout yournewbranch && do your stuff here. This makes it much easier to merge code while following our branching and release standards.

Thanks for your contributions!
Kyle

[robi]

Thanks, I've put my work in https://github.com/ZoneMinder/ZoneMinder/pull/44 and https://github.com/ZoneMinder/ZoneMinder/pull/48
Both need to be pulled in.

Sorry for the mess I caused on GitHub, but everytime I clicked on "propose file change" button, GitHub threw me out with an error 404 not found.
In the end I managed to finally push them into 1.26.

[robi]

For example, you would git clone zoneminder && cd zoneminder && git checkout develop && git checkout yournewbranch && do your stuff here.

I was unable to set up correctly my Git for Windows environment, thus I'm submitting my changes directly though the web interface of GitHub.

[kylejohnson]

I'll test out #44 and #48 as soon as I have time. I want to make sure it displays properly before merging it in.

Thank ya!

[robi]

OK, great, I guess GitHub will drop me a notification when you pull them in.

Just a tip: switch to Hungarian before you test the patches, to see how it looked before.