Zoneminder 1.26.4 - rotation of captured image broken

[McFuzz]

Gents,

It looks like with 1.26.4, the capabilities of rotating a camera is broken... I have a camera that is rotated to the left via the source tab, with capture width of 480 and capture height of 640; with this kind of a setup, image is no longer visible and the logs explode:



I confirmed this happens with 'rotate right' as well. All other options appear to be working...


Thanks for looking

[mastertheknife]

Hi

Please paste the output of the addr2line command here.

[McFuzz]

Sorry - I already reverted back to 1.26.3...

Also, not familiar with addr2line...? Can you please give me a bit more context?

Thanks.

[mastertheknife]

There is a message in your log (shown in your screenshot) that says "backtrace complete, please run the following command for more information"
Running the command on your machine will create output that includes the exact location in the code that causes the crash. This is essential for fixing this.

[McFuzz]

There is a message in your log (shown in your screenshot) that says "backtrace complete, please run the following command for more information"
Running the command on your machine will create output that includes the exact location in the code that causes the crash. This is essential for fixing this.

Gotcha! I'll give it a shot tonight and will report with output

[mastertheknife]

Don't even have to reinstall 1.26.4. Just need to point the addr2line command line from the screenshot at the zmc file from 1.26.4

[twice]

dont know if this is correct but it works

the addr2line command output is rotate right and left:
[/ZoneMinder-master/src/zm_image.cpp:2360 & 2442
/ZoneMinder-master/src/zm_monitor.cpp:2783
/ZoneMinder-master/src/zmc.cpp:263
]
work around is in zm_image.cpp replace

Code: Select all

unsigned char *d_ptr;
				for ( unsigned  int i = new_width-1; i >= 0; i-- )
				{
					d_ptr = rotate_buffer+i;
					for ( unsigned  int j = new_height-1; j >= 0; j-- )
                                       {

with this

Code: Select all

unsigned char *d_ptr;
				for (  int i = new_width-1; i >= 0; i-- )
				{
					d_ptr = rotate_buffer+i;
					for (  int j = new_height-1; j >= 0; j-- )
					{

around lines 2354 and 2442

regards Twice

[mastertheknife]

Looks like i am the one to shoot for this. I did this 23 days ago while working on eliminating signed comparison warnings. It took many changes until the warnings were gone.
https://github.com/ZoneMinder/ZoneMinde ... 1854c5dd09

[twice]

thanks for all your work


regards Twice

[McFuzz]

Awww - I should have checked the thread before redoing the install XD

Thanks for your guys' work! I'll apply the fixes