Page 1 of 2
Editing Zones
Posted: Sun Jul 31, 2016 3:04 pm
by skydiver
Is i my imagination or is the new zone edit screen in 1.30 missing the display of the other zones that are defined for a camera when you are editing the active zone?
Re: Editing Zones
Posted: Sun Jul 31, 2016 7:55 pm
by knight-of-ni
There are two zone views.
The first is called "zones", plural. As the name implies it displays all the zones for a particular monitor.
The second view is called "zone", singular. As that name implies, you see just one zone. This is the view from which you edit the selected zone from. No other zones are visible in this view.
Typically, the first view you see is the zones view. Then, when you select a zone for editing, it brings up the zone view.
This behaviour has not changed with the release of 1.30.0.
Re: Editing Zones
Posted: Sun Jul 31, 2016 8:10 pm
by knight-of-ni
Well apparently I was mistaken. 1.29.0 did show you the rest of the zones on the "zone", singular, view.
Re: Editing Zones
Posted: Mon Aug 01, 2016 1:46 am
by rockedge
There is a bug when I attempt to add a 2nd zone there is no grid displayed in the zone editor but the points are there and can be dragged. So the 2nd or more added zones do not display in any of the zone editor screens.
Re: Editing Zones
Posted: Mon Aug 01, 2016 2:01 am
by skydiver
When defining multiple zones for a screen it is kind of important to be able to see existing other zones on the screen while you add another zone. I have fairly wide angle lenses on my cameras and create a near/middle/far set of zones and too not be able to see where one zone ends ad another begins is important.
Re: Editing Zones
Posted: Mon Aug 01, 2016 12:11 pm
by DVB Hardware
Zone Points 1.30
I am having difficulty adding 5th zone point
I can drag the 4 default points fin but cannot add any with the "+"
Re: Editing Zones
Posted: Mon Aug 01, 2016 5:20 pm
by knight-of-ni
Yeah, it looks like we need to take a closer look at this.
Re: Editing Zones
Posted: Mon Aug 01, 2016 8:36 pm
by DVB Hardware
Sorry i did not notice the "+ -" in the table to add a zone point
My monitor was too bright to notice them.
I assumed from all the searching to add a zone point was to use
the keyboard + / - , It works ok clicking them with the mouse.
Jimmy
Re: Editing Zones
Posted: Wed Aug 03, 2016 2:26 pm
by knight-of-ni
Gentlemen,
iconnor has created a PR to show all the polgons on the zone editing screen.
I won't have time to build and test this until the weekend.
However, we could merge this quicker if one of you would be willing to make the proposed changes to your own system and then report back the status:
https://github.com/ZoneMinder/ZoneMinder/pull/1576
The changes are all http, php, css changes, so you could make the changes to your system by hand if you don't want to build your own package.
Re: Editing Zones
Posted: Fri Aug 05, 2016 3:19 am
by rockedge
I made all the changes and I can see all the zone polygons except for an "Inactive" one.
So to run a test I then modified /web/skins/classic/css/dark/views/zone.css by adding
line 119:
Code: Select all
.Inactive {
stroke: #57C03C;
fill: #57C03C;
}
in /web/skins/classic/css/dark/views/zones.css added:
line 21:
Code: Select all
.Inactive {
stroke: #57C03C;
fill: #57C03C;
}
And I returned this line in /web/skins/classic/views/zone.php:
Line 236
Code: Select all
<polygon id="zonePoly" points="<?php echo $zone['AreaCoords'] ?>" class="Editing <?php echo $zone['Type'] ?>"
To:
Code: Select all
<polygon id="zonePoly" points="<?php echo $zone['AreaCoords'] ?>" class="<?php echo $zone['Type'] ?>"
Then it worked completely in the dark skin.
Re: Editing Zones
Posted: Fri Aug 05, 2016 3:40 am
by rockedge
I made the same change to the "flat' and "classic" skin and all the zone types are visible when there are 2 or more.
Re: Editing Zones
Posted: Sat Aug 13, 2016 2:58 pm
by rockedge
I just upgraded a clients machine from 1.29 to 1.30.0 using the iconner PPA for Ubuntu and noticed that multiple zones are not visible. Are the modifications present?
Re: Editing Zones
Posted: Sun Sep 04, 2016 5:21 pm
by lightguy48
I am trying to fix this issue in 1.3, and after editing the files mentioned (except I edited the Classic CSS files as I don't use the Dark skin) I still cannot get the old behavior to return, it still won't show me the other defined zones while I'm editing a zone so it's extremely difficult to edit zones to make sure they don't overlap or have missing coverage.
But one thing I noticed is my zone.php did not have Editing comment in the file.
I restarted apache and zoneminder after making the changes, does something else need to happen?
Re: Editing Zones
Posted: Sun Sep 04, 2016 7:52 pm
by rockedge
did you try to clear the browser cache? I can not remember if this mattered...
Re: Editing Zones
Posted: Mon Sep 05, 2016 4:18 pm
by lightguy48
Yes & I tried a different browser too. I'll try rebooting my server and see if there is some service I failed to restart.
But I'm still unsure about editing the zone.php because mine didn't have the "editing" word to be removed. But my line count is different too for zone.php