ZoneMinder::Control::Reolink refactoring
Posted: Sat Feb 20, 2021 1:18 pm
I took the liberty of a first stab at the source - see attachment.
It shall be deemed work-in-progress because it is neither finished, nor sufficiently tested (beyond a perl -c) yet.
It seems, that compared with the other Control modules the Reolink code is at technical debt level 9000.
For now removed like 50% of the code, which was just brutal copy&paste boilerplate and suddenly the
code starts revealing what it aims to do. My guess is that the 39000 bytes can be cut to 10000 and
hopefully I will eventually make the Reolink module the shiniest one.
Will need more quality time with the code still, so JFYI that something like that is happening.
PS: "Invalid file extension for .pm files..." - so .txt it is.
It shall be deemed work-in-progress because it is neither finished, nor sufficiently tested (beyond a perl -c) yet.
It seems, that compared with the other Control modules the Reolink code is at technical debt level 9000.
For now removed like 50% of the code, which was just brutal copy&paste boilerplate and suddenly the
code starts revealing what it aims to do. My guess is that the 39000 bytes can be cut to 10000 and
hopefully I will eventually make the Reolink module the shiniest one.
Will need more quality time with the code still, so JFYI that something like that is happening.
PS: "Invalid file extension for .pm files..." - so .txt it is.