A memory leak located?

[pygr]

Version 1.37.45

Before another memory allocation is made for

Code: Select all

packet->image

, is the old one deallocated in the method Monitor::Decode() in zm_monitor.cpp?

If I put

Code: Select all

delete packet->image;packet->image = nullptr;

near the end of Decode(), zoneminder seems to leak memory less badly. I haven't noticed any bad side effects.

I'm seeing other memory leaks, but I want to get a better handle on them before I post anything more here.

[Magic919]

I’d suggest using Slack as that’s where the Developers hang out.

[iconnor]

I'm here. I'll take a look.

[iconnor]

If you delete the image, then we can't do analysis on it later....

The image is deleted when the packet is deleted.

[pygr]

Does turning analysis off cause a memory leak? In my setup I turn off analysis because, instead, I have the ONVIF event listener triggering events.

I'm now thinking perhaps it's better to put the "delete" command just before the "new" command for "packet->image" towards the beginning of Monitor::Decode(). That way, if I ever decide to turn on analysis, things should work properly.

[pygr]

Further investigation disproves the notion that packet->image is involved with a memory leak.

Sorry, my bad.

[pygr]

I’d suggest using Slack as that’s where the Developers hang out.

Good suggestion! Thanks.