Smaller problem in "zm_html_view_settings.php"

If you've made a patch to quick fix a bug or to add a new feature not yet in the main tree then post it here so others can try it out.
Post Reply
desnaturado
Posts: 11
Joined: Wed Aug 04, 2004 7:02 pm
Location: Ilhabela, Brazil

Smaller problem in "zm_html_view_settings.php"

Post by desnaturado »

I have no idea who is responsible for the php-files of ZM, but there is a bit of an error in the above mentioned file:

1) There is no </form> tag. Put one right after the </table> tag.
2) The <form> tag and the hidden <input> tags come right after the <table ...> tag. How ugly ;-) Better put them before the <table> tag, so that the table is completely "embraced" by the <form> tags.
3) The table column width is not defined. Something like ...

Code: Select all

<table ...>
<col width="50%">
<col width="50%">
<tr ...>
... makes that table better defined.
4) A "reset" button would be nice, which sets the input forms back to "32768"
something like ...

Code: Select all

<input type="button" value="Reset" class="form" onClick="resVal()">
...
<script type="text/javascript">
function resVal() {
	document.getElementById("new_brightness").value="32768";
	document.getElementById("new_contrast").value="32768";
	document.getElementById("new_hue").value="32768";
	document.getElementById("new_colour").value="32768";
	document.getElementById("settings_form").submit();
}
</script>
...will do the job.


Thanks

Juergen
Post Reply